Skip to content

M2351: Add license file for default secure library/executable #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2018
Merged

M2351: Add license file for default secure library/executable #8193

merged 3 commits into from
Oct 8, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Sep 20, 2018

Description

This PR adds license file for default secure library/executable.

Related PR

#8049

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

0xc0170
0xc0170 approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question : is it described what are these 2 files in the folder ? .hex and .o file?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

To my above question, the answer is #8049 (comment) (shall this be documented somewhere, or is it?)

@ccli8
Copy link
Contributor Author

ccli8 commented Sep 21, 2018

@0xc0170 I add readme in 1d4e0c4.

@ccli8 ccli8 force-pushed the nuvoton_m2351_license branch from 1d4e0c4 to 96ce8ae Compare September 28, 2018 03:50
@ccli8
Copy link
Contributor Author

ccli8 commented Sep 28, 2018

Do rebase and rename LICENSE.txt LICENSE.

@0xc0170 0xc0170 requested a review from AnotherButler October 1, 2018 11:10
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

@AnotherButler Please review new file: readme

Copy edit REAMDE.md
cd996cd 
Copy edit file, mostly for active voice and consistent spelling.
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3246
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8193/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Test : SUCCESS

Build number : 3054
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8193/3054

@studavekar
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2849
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8193/

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2859
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8193/

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2865
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8193/

@NirSonnenschein
Copy link
Contributor

possible license issue : retrying
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2869
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8193/

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : SUCCESS

Build number : 2872
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8193/

@cmonr cmonr merged commit b81c8a9 into ARMmbed:master Oct 8, 2018
@ccli8 ccli8 deleted the nuvoton_m2351_license branch October 9, 2018 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ccli8 @0xc0170 @mbed-ci @studavekar @NirSonnenschein @AnotherButler @deepikabhavnani @cmonr